Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-16765: The API calls in modeler is execute twice #1842

Open
wants to merge 9 commits into
base: next
Choose a base branch
from

Conversation

henryjonathanquispe
Copy link

@henryjonathanquispe henryjonathanquispe commented Jun 18, 2024

Issue & Reproduction Steps

  1. Go to modeler
  2. Create a process and a task with Screens and Display Next Assigned Task to Task Assignee enable
  3. Open the debuger
  4. Click on any task and see th calls in Network

Solution

  • Add validation to Inspector Panel in Modeler

How to Test

  • Go to modeler
  • Create a process and a task with Screens and Display Next Assigned Task to Task Assignee enable
  • Open the browser debugger
  • Click on any task and see the calls in Network

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next

Copy link

cypress bot commented Jun 18, 2024

modeler    Run #1496

Run Properties:  status check failed Failed #1496  •  git commit 629c5ed8df: FOUR-16765: The API calls in modeler is execute twice
Project modeler
Branch Review feature/FOUR-16765
Run status status check failed Failed #1496
Run duration 03m 03s
Commit git commit 629c5ed8df: FOUR-16765: The API calls in modeler is execute twice
Committer henryjonathanquispe
View all properties for this run ↗︎

Test results
Tests that failed  Failures 4
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 13
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 33
View all changes introduced in this branch ↗︎

Tests for review

Failed  Pools.cy.js • 1 failed test

View Output

Test Artifacts
Pools > moves boundary event to another process when dragged to that pool Test Replay Screenshots
Failed  MessageFlows.cy.js • 1 failed test

View Output

Test Artifacts
Message Flows > should connect message end event to boundary message event in different pools Test Replay Screenshots
Failed  BoundaryTimerEvent.cy.js • 1 failed test

View Output

Test Artifacts
Boundary Timer Event > moves to another task when dragged over Test Replay Screenshots
Failed  Tasks.cy.js • 1 failed test

View Output

Test Artifacts
Tasks > Update task element destination Test Replay Screenshots
Failed  CopyElements.cy.js • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 92 specs in Cypress Cloud.

@pmPaulis pmPaulis requested review from rodriquelca and caleeli June 19, 2024 13:03
Copy link
Contributor

@caleeli caleeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, but seems needs a rebase, since some tests are failing

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants