Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-14067: Pan Tool in overview should be disabled. #1792

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

eiresendez
Copy link
Contributor

@eiresendez eiresendez commented Feb 7, 2024

Issue & Reproduction Steps

Expected behavior:

  • The PanTool should not be enabled for the Overview, and this should not affect the display of the padding

Actual behavior:

  • The entire process can be modified.

Solution

  • Since by default we can only move the paper and not the elements, the 'Pan Tool' button has been hidden when the Modeler is in 'inflight' mode.
Screen.Recording.2024-02-07.at.10.01.29.a.m.mov

How to Test

  1. Go to request
  2. Open a completed request
  3. Go to overview
  4. Click on PanTool and move the process components

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next

Copy link

cypress bot commented Feb 7, 2024

Passing run #1098 ↗︎

0 276 83 0 Flakiness 0

Details:

FOUR-14067: Pan Tool in overview should be disabled.
Project: modeler Commit: d1242aa883
Status: Passed Duration: 05:32 💡
Started: Feb 7, 2024 5:40 PM Ended: Feb 7, 2024 5:45 PM

Review all test suite changes for PR #1792 ↗︎

Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@ryancooley ryancooley merged commit 64a6252 into next Feb 7, 2024
10 of 34 checks passed
@ryancooley ryancooley deleted the observation/FOUR-14067 branch February 7, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants