Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-13911: Collaborative modeler is working in different servers and… #1787

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

rodriquelca
Copy link
Contributor

@rodriquelca rodriquelca commented Jan 29, 2024

… same process

Issue & Reproduction Steps

Expected behavior:
The collaborative modeler should work between users in the same process and server.
Actual behavior:
Both users are displaying in both processes (collaborative modeler). However, Those users are in different servers.

Solution

  • Server Url in windows.Processmaker.app.url was added to a room name

How to Test

Test the steps above

  1. Login in the server https://next-qa.processmaker.net/
  2. Import a process
  3. Open the process imported
  4. Login in the server https://ci-3ad848237b.engk8s.processmaker.net/ (different user to Admin)
  5. Import the same process
  6. Open the process imported

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next
ci:deploy

Copy link

@rodriquelca rodriquelca requested a review from caleeli January 29, 2024 18:00
Copy link

cypress bot commented Jan 29, 2024

Passing run #1083 ↗︎

0 276 83 0 Flakiness 0

Details:

FOUR-13911: Collaborative modeler is working in different servers and…
Project: modeler Commit: 1025ef6954
Status: Passed Duration: 05:54 💡
Started: Jan 29, 2024 10:05 PM Ended: Jan 29, 2024 10:11 PM

Review all test suite changes for PR #1787 ↗︎

@ryancooley ryancooley merged commit 2595724 into next Jan 29, 2024
13 of 49 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-13911 branch January 29, 2024 22:34
@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-f2e205b6a8.engk8s.processmaker.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants