Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Vite to work with Modeler. #1784

Merged
merged 20 commits into from
Jan 26, 2024
Merged

Getting Vite to work with Modeler. #1784

merged 20 commits into from
Jan 26, 2024

Conversation

josechirivella
Copy link
Contributor

@josechirivella josechirivella commented Jan 16, 2024

This is not a PR to introduce the Vite build tools, just some workarounds we had to do to get Vite to play nice with Modeler

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:vue-form-elements:vite-2
ci:processmaker:vite-js-integration
ci:screen-builder:vite-2
ci:vue-multiselect:FOUR-6840
.

Copy link

cypress bot commented Jan 16, 2024

Passing run #1078 ↗︎

0 276 83 0 Flakiness 0

Details:

Getting Vite to work with Modeler.
Project: modeler Commit: ace616b8ed
Status: Passed Duration: 05:39 💡
Started: Jan 26, 2024 4:24 AM Ended: Jan 26, 2024 4:30 AM

Review all test suite changes for PR #1784 ↗︎

Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@ryancooley ryancooley merged commit 3ebe5fc into next Jan 26, 2024
6 of 19 checks passed
@ryancooley ryancooley deleted the vite-workaround branch January 26, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants