Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-13068: Asset generation UI is toggled off on generation error #1773

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

TinCodes
Copy link
Contributor

@TinCodes TinCodes commented Jan 4, 2024

Issue & Reproduction Steps

"Generating..." message does not disappear when error is thrown in AI Asset Generation in Modeler.

Expected behavior:
Whenever an error is shown on the asset generation, the "Generating..." popup that replaces the bottom rail with BPMN controls should also disappear.

Actual behavior:
On error, the "Generating..." popup is still being shown.

Solution

  • Change the variable that toggles the component to false on error.

How to Test

Test the steps above

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

Copy link

cypress bot commented Jan 4, 2024

Passing run #1034 ↗︎

0 276 83 0 Flakiness 0

Details:

FOUR-13068: Asset generation UI is toggled off on generation error
Project: modeler Commit: 201dfca86e
Status: Passed Duration: 05:41 💡
Started: Jan 4, 2024 4:23 PM Ended: Jan 4, 2024 4:28 PM

Review all test suite changes for PR #1773 ↗︎

@ryancooley ryancooley merged commit ec3fe9b into next Jan 4, 2024
18 checks passed
@ryancooley ryancooley deleted the FOUR-13068 branch January 4, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants