Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modeler Updates V2 #1758

Merged
merged 35 commits into from
Jan 9, 2024
Merged

Modeler Updates V2 #1758

merged 35 commits into from
Jan 9, 2024

Conversation

nolanpro
Copy link
Contributor

@nolanpro nolanpro commented Dec 4, 2023 •
edited
Loading

@nolanpro nolanpro changed the base branch from develop to next December 4, 2023 22:06
@rodriquelca
Copy link
Contributor

rodriquelca commented Dec 5, 2023 •
edited
Loading

@nolanpro I have the next observation. for pool, text anotation and custom shapes

drag_and_drop.webm

rodriquelca
rodriquelca reviewed Dec 5, 2023
View reviewed changes
src/components/modeler/Modeler.vue Outdated
onMouseUp() {
onMouseUp(event) {
if (window.ProcessMaker.mouseDownDrag) {
window.ProcessMaker.EventBus.$emit('custom-pointerclick', event);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix identation to 8 spaces

src/components/modeler/Modeler.vue Outdated
onMouseUp(event) {
if (window.ProcessMaker.mouseDownDrag) {
window.ProcessMaker.EventBus.$emit('custom-pointerclick', event);
window.ProcessMaker.mouseDownDrag = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix identation

@cypress Cypress
Copy link

cypress bot commented Dec 5, 2023 •
edited
Loading

21 failed tests on run #1018 ↗︎

21 255 83 0 Flakiness 0

Details:

Merge 67f7faa into 64bd77f...
Project: modeler Commit: b8092fd2f4 ℹ️
Status: Failed Duration: 10:38 💡
Started: Dec 18, 2023 7:38 PM Ended: Dec 18, 2023 7:49 PM
Failed  IntermediateMessageThrowEvent.cy.js • 7 failed tests

View Output

Test Artifacts
Intermediate Message Throw Event > can render an intermediate message throw event Screenshots
Intermediate Message Throw Event > can create a message when intermediate message throw event is dragged on Screenshots
Intermediate Message Throw Event > can remove the message when intermediate message throw event is deleted Screenshots
Intermediate Message Throw Event > retains new message name when clicking off and on intermediate message throw event Screenshots
Intermediate Message Throw Event > associates and renames message on intermediate message catch event Screenshots
Intermediate Message Throw Event > does not create duplicate messages on undo/redo Screenshots
Intermediate Message Throw Event > retains message name after loading XML Screenshots
Failed  MessageFlows.cy.js • 1 failed test

View Output

Test Artifacts
Message Flows > Can connect two pools with a message flow Screenshots
Failed  CopyElements.cy.js • 2 failed tests

View Output

Test Artifacts
Copy element > copies error on Error End Event Screenshots
Copy element > copies message on Message Event Screenshots
Failed  ErrorEndEvent.cy.js • 3 failed tests

View Output

Test Artifacts
Error End Event > Can create an error end event Screenshots
Error End Event > can edit the error end event name Screenshots
Error End Event > should not create duplicate errors on undo/redo Screenshots
Failed  zoomControl/ZoomControl.cy.js • 3 failed tests

View Output

Test Artifacts
Zoom control test > should update modeler according (-) zoom-out (3) times Screenshots
Zoom control test > should update modeler according (+) zoom-in (8) times Screenshots
Zoom control test > should reset modeler after (+) zoom-in (8) times Screenshots

The first 5 failed specs are shown, see all 9 specs in Cypress Cloud.

Review all test suite changes for PR #1758 ↗︎

@cypress Cypress
Copy link

cypress bot commented Dec 21, 2023 •
edited
Loading

Passing run #1060 ↗︎

0 276 83 0 Flakiness 0

Details:

Modeler Updates V2
Project: modeler Commit: 32ff9b2045
Status: Passed Duration: 05:53 💡
Started: Jan 8, 2024 8:49 PM Ended: Jan 8, 2024 8:55 PM

Review all test suite changes for PR #1758 ↗︎

@nolanpro nolanpro mentioned this pull request Jan 2, 2024
Merged
@processmaker-sonarqube ProcessMaker SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% 0.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@ryancooley ryancooley merged commit d62e19e into next Jan 9, 2024
18 checks passed
@ryancooley ryancooley deleted the epic/FOUR-11573 branch January 9, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodriquelca rodriquelca rodriquelca left review comments

@oscarmurillo oscarmurillo Awaiting requested review from oscarmurillo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nolanpro @rodriquelca @ryancooley @pmoskrojas