Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing Vite 🚀 #1650

Closed
wants to merge 29 commits into from
Closed

Introducing Vite 🚀 #1650

wants to merge 29 commits into from

Conversation

josechirivella
Copy link
Contributor

@josechirivella josechirivella commented Aug 15, 2023 •
edited
Loading

@josechirivella
Added vite, loaders for svg, yaml and bpmnlint
5651251
@josechirivella
Merge remote-tracking branch 'origin/develop' into vite
3243425
@josechirivella
Restore babel config to the way it was
9c93d88
@josechirivella
SVG fixes and FontAwesome fix
9e8b866 
* Added the index to the root level
* Added vue alias since it was needed for Vite
@josechirivella
FOUR-6840 Eslint linting fixes
95b57ac
@josechirivella
Merge branch 'develop' into vite
2b87cec 
# Conflicts:
#	package-lock.json
#	package.json
#	src/components/crown/crownButtons/cloneButton.vue
#	src/components/nodes/association/association.vue
#	src/components/nodes/boundaryEscalationEvent/boundaryEscalationEvent.vue
#	src/components/nodes/boundaryTimerEvent/index.js
#	src/components/nodes/dataInputAssociation/dataInputAssociation.vue
#	src/components/nodes/dataOutputAssociation/dataOutputAssociation.vue
#	src/components/nodes/intermediateTimerEvent/index.js
#	src/components/toolbar/ToolBar.vue
#	src/main.js
#	src/setup/extensions/customMarker.js
@josechirivella
Updated the branch with develop
186d087
@josechirivella
Added the VFE css back
cc16a96
@josechirivella
Added resolver mapper for jest svg loader
4deeba3
@josechirivella
Removed unused import
86b77d9
@josechirivella
Added sourcemaps and externals
b68b0c5
@josechirivella josechirivella self-assigned this Aug 15, 2023
@josechirivella josechirivella marked this pull request as ready for review August 15, 2023 17:58
@josechirivella josechirivella mentioned this pull request Aug 15, 2023
Closed
@josechirivella
Targeting the STM branch for github workflow
6d67066
@josechirivella
Cleaning
b413215 
* Removed source maps
* Added more external deps
* Making the default to be install
@josechirivella
Reverting back to exporting the install
b38a6ba
@josechirivella
Removing the processmaker external dep and using a better way to expo…
76a037e 
…rts the components from Modeler
@josechirivella
Removed the externals of processmaker and testing out the default or …
b5b5647 
…not when declaring
@josechirivella
Added index.js to multiple folders and renamed eslint to .cjs
a51650b 
* Added @babel/preset-env to be used and renamed the babel config to json
@josechirivella
Renamed vue config file to cjs
bebed3f
@josechirivella
Fixing linting issues
b38cdf6
@josechirivella
Renamed jest config to cjs
dcfbb7f
@josechirivella
Added cssInjectedByJsPlugin dep and changed the target to build the n…
a360dae 
…odes/index
@josechirivella
Renamed the .cjs files to .js back
8bb5e09
@processmaker-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)
Failed condition 10.6% 10.6% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

@processmaker-sonarqube ProcessMaker SonarQube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
7.9% 7.9% Duplication

@cypress Cypress
Copy link

cypress bot commented Dec 5, 2023

90 failed tests on run #978 ↗︎

90 0 29 240 Flakiness 0

Details:

Merge 9649777 into a48423b...
Project: modeler Commit: f2c53a7f55 ℹ️
Status: Failed Duration: 04:00 💡
Started: Dec 5, 2023 5:49 PM Ended: Dec 5, 2023 5:53 PM
Failed  Modeler.cy.js • 1 failed test

View Output

Test Artifacts
Modeler > Create a simple process Screenshots
Failed  IntermediateMessageThrowEvent.cy.js • 1 failed test

View Output

Test Artifacts
Intermediate Message Throw Event > can render an intermediate message throw event Screenshots
Failed  Pools.cy.js • 1 failed test

View Output

Test Artifacts
Pools > Update pool name Screenshots
Failed  MessageFlows.cy.js • 1 failed test

View Output

Test Artifacts
Message Flows > Can connect two pools with a message flow Screenshots
Failed  Documentation.cy.js • 1 failed test

View Output

Test Artifacts
Documentation accordion > has a dedicated documentation inspector accordion Screenshots

The first 5 failed specs are shown, see all 90 specs in Cypress Cloud.

Review all test suite changes for PR #1650 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodriquelca rodriquelca Awaiting requested review from rodriquelca

@devmiguelangel devmiguelangel Awaiting requested review from devmiguelangel

@caleeli caleeli Awaiting requested review from caleeli

@danloa danloa Awaiting requested review from danloa

Assignees

@josechirivella josechirivella

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@josechirivella