Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement tagging of local results #63

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: implement tagging of local results #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d54232d
chore(deps): bump deps
mjugl Dec 16, 2024
a235659
feat: prefer bitnami docker image in local MinIO deployment
mjugl Dec 16, 2024
4a12e1f
feat: remove manual creation of bucket from test workflow
mjugl Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/integration-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ jobs:
run: poetry install
- name: Copy environment variables
run: cp .env.example .env.test
- name: Create local bucket
run: poetry run flame-result migrate --no-verify "$MINIO_ROOT_USER" "$MINIO_ROOT_PASSWORD" "$MINIO_LOCAL_BUCKET_NAME"
- name: Run tests
run: poetry run pytest
env:
Expand All @@ -57,10 +55,11 @@ jobs:
minio:
# not possible to use official minio image since it requires commands to start up
# which gh doesn't support :(
image: bitnami/minio:2024.1.16
image: bitnami/minio:2024.12.13
env:
MINIO_ROOT_USER: ${{env.MINIO_ROOT_USER}}
MINIO_ROOT_PASSWORD: ${{env.MINIO_ROOT_PASSWORD}}
MINIO_DEFAULT_BUCKETS: ${{env.MINIO_LOCAL_BUCKET_NAME}}
ports:
- 9000:9000
options: >-
Expand Down
13 changes: 2 additions & 11 deletions docker/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,11 @@
services:

minio:
image: quay.io/minio/minio:RELEASE.2024-01-16T16-07-38Z
volumes:
- minio-data:/mnt/data
- minio-config:/etc/config
image: bitnami/minio:2024.12.13
environment:
- MINIO_VOLUMES=/mnt/data
- MINIO_CONFIG_ENV_FILE=/etc/config/.env
- MINIO_DEFAULT_BUCKETS=flame
env_file:
- .env
ports:
- "9000:9000" # s3 api
- "9001:9001" # web console
command: [ "server", "--address", ":9000", "--console-address", ":9001" ]

volumes:
minio-data:
minio-config:
Loading
Loading