fix: change env vars for MinIO root user and password

PrivateAIM · Jan 31, 2024 · 49949f1 · 49949f1
1 parent 00b7431
commit 49949f1
Showing 1 changed file with 8 additions and 11 deletions.
diff --git a/.github/workflows/integration-test.yml b/.github/workflows/integration-test.yml
@@ -1,8 +1,8 @@
 name: Integration test
 
 env:
-  MINIO_SERVER_ACCESS_KEY: admin
-  MINIO_SERVER_SECRET_KEY: s3cr3t_p4ssw0rd
+  MINIO_ROOT_USER: admin
+  MINIO_ROOT_PASSWORD: s3cr3t_p4ssw0rd
   MINIO_LOCAL_BUCKET_NAME: flame
   MINIO_REMOTE_BUCKET_NAME: upload
 
@@ -29,16 +29,16 @@ jobs:
       - name: Install dependencies
         run: poetry install
       - name: Create local bucket
-        run: poetry run flame-result migrate --no-verify "$MINIO_SERVER_ACCESS_KEY" "$MINIO_SERVER_SECRET_KEY" "$MINIO_LOCAL_BUCKET_NAME"
+        run: poetry run flame-result migrate --no-verify "$MINIO_ROOT_USER" "$MINIO_ROOT_PASSWORD" "$MINIO_LOCAL_BUCKET_NAME"
       - name: Create remote bucket
-        run: poetry run flame-result migrate --no-verify "$MINIO_SERVER_ACCESS_KEY" "$MINIO_SERVER_SECRET_KEY" "$MINIO_REMOTE_BUCKET_NAME"
+        run: poetry run flame-result migrate --no-verify "$MINIO_ROOT_USER" "$MINIO_ROOT_PASSWORD" "$MINIO_REMOTE_BUCKET_NAME"
       - name: Run tests
-        run: PYTEST__MINIO__ACCESS_KEY="$MINIO_SERVER_ACCESS_KEY" \
-          PYTEST__MINIO__SECRET_KEY="$MINIO_SERVER_SECRET_KEY" \
+        run: PYTEST__MINIO__ACCESS_KEY="$MINIO_ROOT_USER" \
+          PYTEST__MINIO__SECRET_KEY="$MINIO_ROOT_PASSWORD" \
           PYTEST__MINIO__BUCKET="$MINIO_LOCAL_BUCKET_NAME" \
           PYTEST__MINIO__ENDPOINT="localhost:9000" \
-          PYTEST__REMOTE__ACCESS_KEY="$MINIO_SERVER_ACCESS_KEY" \
-          PYTEST__REMOTE__SECRET_KEY="$MINIO_SERVER_SECRET_KEY" \
+          PYTEST__REMOTE__ACCESS_KEY="$MINIO_ROOT_USER" \
+          PYTEST__REMOTE__SECRET_KEY="$MINIO_ROOT_PASSWORD" \
           PYTEST__REMOTE__BUCKET="$MINIO_REMOTE_BUCKET_NAME" \
           PYTEST__REMOTE__ENDPOINT="localhost:9000" \
           poetry run pytest
@@ -48,8 +48,5 @@ jobs:
         # not possible to use official minio image since it requires commands to start up
         # which gh doesn't support :(
         image: bitnami/minio:2024.1.16
-        env:
-          MINIO_SERVER_ACCESS_KEY: ${{env.MINIO_SERVER_ACCESS_KEY}}
-          MINIO_SERVER_SECRET_KEY: ${{env.MINIO_SERVER_SECRET_KEY}}
         ports:
           - 9000:9000