Feature: Revise Message Sending Functionality #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiCanio
added
enhancement
DiCanio
force-pushed
the
feature/73-allow-sending-messages-to-specific-recipients
branch
from
aad4ac8 to
e3e9efa
Compare
Adds functionality to send messages to specific recipients instead of using a broadcast. This is expected to be used in conjunction with the discovery endpoints. Also guards the recipients in a way such that only messages to participating nodes within an analysis context are valid. When trying to send messages to other participants then this will lead to an error. Furthermore adjusts the broadcast endpoint. This change is made since everything is dependant upon an analysis in the first place and this change makes that clear.
DiCanio
force-pushed
the
feature/73-allow-sending-messages-to-specific-recipients
branch
from
e3e9efa to
0fa6b96
Compare
DiCanio
deleted the
feature/73-allow-sending-messages-to-specific-recipients
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #72 and #73
Adjusts the existing broadcast endpoint to follow the follwing template:
/analyses/{:id}/messages/broadcastsAlso adds a new functionality to send messages to specific analysis participants without broadcasting it. For this the endpoint
/analyses/{:id}/messagescan be used viaPOST.