Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mounting for other entities and fix bot not dismounting when the vehicle is gone #3384

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Mounting for other entities and fix bot not dismounting when the vehicle is gone #3384

wants to merge 17 commits into from
+63 −16

Conversation

qwqtoday
Copy link

@qwqtoday qwqtoday commented May 22, 2024 •
edited
Loading

maybe I will add the entity.passengers and the entity.vehicle attributes later on prismarine-entity

@qwqtoday
Copy link
Author

qwqtoday commented May 22, 2024 •
edited
Loading

it was ok before I merge master
https://github.com/PrismarineJS/mineflayer/actions/runs/9185408953

@qwqtoday qwqtoday mentioned this pull request May 22, 2024
Open
@qwqtoday
Copy link
Author

/fixlint

@rom1504bot
Copy link
Contributor

I fixed all linting errors with npm run fix!

@qwqtoday qwqtoday changed the title Mounting for other entities and fix bot not dismounting when the vehicle is gone 🚨🚨🚨 really important pr, hope you will merge asap 🚨 Mounting for other entities and fix bot not dismounting when the vehicle is gone May 31, 2024
@extremeheat extremeheat changed the title 🚨🚨🚨 really important pr, hope you will merge asap 🚨 Mounting for other entities and fix bot not dismounting when the vehicle is gone Mounting for other entities and fix bot not dismounting when the vehicle is gone Jun 1, 2024
@extremeheat
Copy link
Member

Failing CI because of your PR's changes

@qwqtoday
Copy link
Author

qwqtoday commented Jun 9, 2024 •
edited
Loading

You need to merge this first PrismarineJS/prismarine-entity#75
This pr uses Entity.passengers and Entity.vehicle based that need that change in prismarine-entity

@rom1504
Copy link
Member

rom1504 commented Jun 9, 2024

Please change package.json to point to the branch in prismarine-entity to see if it works

@socket-security Socket Security
Copy link

socket-security bot commented Jun 10, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@qwqtoday
Copy link
Author

It should work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
PR Triage
Status: Needs triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qwqtoday @rom1504bot @extremeheat @rom1504