Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add preview images and chore: add Nord theme #5

Merged
merged 6 commits into from
Oct 22, 2022
Merged

docs: add preview images and chore: add Nord theme #5

merged 6 commits into from
Oct 22, 2022

Conversation

Derpitron
Copy link
Contributor

68e5102 adds preview images to all the themes, for a good browsing/theme selection experience.

3eccd1f adds my Nord theme to this repository under the GPL-3.0-or-later license.

It might be best to separate this PR into two, so that it is more organized.

Copy link
Member

@DioEgizio DioEgizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add licenses to images too to comply with reuse

themes/Nord/README.md Outdated Show resolved Hide resolved
@Derpitron
Copy link
Contributor Author

What image license should I use? Is CC-1.0 fine?

@DioEgizio
Copy link
Member

CC0-1.0 is fine yeah

Copy link
Member

@DioEgizio DioEgizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newline and you forgot to rename the Dracula png license file

@Derpitron
Copy link
Contributor Author

My fork is quite messed up right now, give me some time

Copy link
Member

@DioEgizio DioEgizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@DioEgizio DioEgizio merged commit 5df2d0c into PrismLauncher:main Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants