-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add preview images and chore: add Nord theme #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add licenses to images too to comply with reuse
Co-authored-by: DioEgizio <[email protected]> Signed-off-by: hydino2085143 <[email protected]>
What image license should I use? Is CC-1.0 fine? |
CC0-1.0 is fine yeah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add newline and you forgot to rename the Dracula png license file
My fork is quite messed up right now, give me some time |
themes/Catppuccin-Macchiato/preview-catppuccin-macchiato.png.license
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
68e5102 adds preview images to all the themes, for a good browsing/theme selection experience.
3eccd1f adds my Nord theme to this repository under the
GPL-3.0-or-later
license.It might be best to separate this PR into two, so that it is more organized.