Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CHANGE BASE AND REBASE) Include server error forwarding #9

Closed
wants to merge 5 commits into from

Conversation

liam-sbhoo
Copy link
Collaborator

Development

With the development of server (PR 1 and PR 2)

  • The client can now raise inference-related errors (raised on the server) to the users

Question

  • Calling fit with conflicting X_train and y_train wouldn't raise an error until predict is called - calling fit would only upload the dataset, but not actually fitting it on TabPFN.
  • Should we change this?

Example

The following demonstrates the behavior when the client calls predict with conflicting dataset:

# Load data
from sklearn.datasets import load_breast_cancer, load_digits
from sklearn.model_selection import train_test_split

breast_X, breast_y = load_breast_cancer(return_X_y=True)
breast_X_train, breast_X_test, breast_y_train, breast_y_test = train_test_split(X, y)
digits_X, digits_y = load_digits(return_X_y=True)
digits_X_train, digits_X_test, digits_y_train, digits_y_test = train_test_split(digits_X, digits_y)

# Init TabPFN
from tabpfn_client import tabpfn_classifier
tabpfn_classifier.init(use_server=True)

# Predict with TabPFN
from tabpfn_client import TabPFNClassifier

tabpfn = TabPFNClassifier()
tabpfn.fit(breast_X_train, breast_y_train)
tabpfn.predict(digits_X_test)

Outcome at the client:
image

Copy link
Collaborator Author

@liam-sbhoo liam-sbhoo Nov 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Change PR base and rebase
  • Update submodule upon merging common

@liam-sbhoo liam-sbhoo changed the title (REVIEW AFTER CONFIG PR, REBASE) Include server error forwarding (CHANGE BASE AND REBASE) Include server error forwarding Nov 15, 2023
@liam-sbhoo
Copy link
Collaborator Author

Not relevant anymore.

@liam-sbhoo liam-sbhoo closed this May 23, 2024
@liam-sbhoo liam-sbhoo deleted the include-server-error-forwarding branch May 23, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant