-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate gdpr api #7
Conversation
Hey Sam and Noah, please also take a look at this client PR when you have the time. Thanks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Liam, thanks for the great PR!
I couldn't think of a better word for UserDataClient either..
maybe @SamuelGabriel want to look over it as well, but its looking good for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot :) This looks pretty gdpr compliant 😆
I only reviewed it superficially, sorry. Maybe we could talk a bit more in depth about the codebase in our meeting next week.
One general point: I think we should very carefully think about a modularization s.t. we can share a lot of code between local and server TabPFN. But how you did it is fine for now, I think.
Development
Demonstration of GDPR API usage
Note
I couldn't think of a cool name for "UserDataClient". Let me know if you've got anything, I will be glad to change it :)