Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate gdpr api #7

Merged
merged 7 commits into from
Nov 12, 2023
Merged

Integrate gdpr api #7

merged 7 commits into from
Nov 12, 2023

Conversation

liam-sbhoo
Copy link
Collaborator

@liam-sbhoo liam-sbhoo commented Oct 25, 2023

Development

  • Add support for GDPR APIs :)
  • Refactoring

Demonstration of GDPR API usage

from tabpfn_client import tabpfn_classifier, UserDataClient

tabpfn_classifier.init(use_server=True)
data_client = UserDataClient()

# all available API(s) are as followed:
data_client.get_data_summary()  # to get summary of uploaded data
data_client.download_all_datasets(save_dir)  # get a zip file of all uploaded data
data_client.delete_dataset(certain_dataset_uid)  # to delete given train set / test set
data_client.delete_all_datasets()  # to delete all uploaded datasets
data_client.delete_user_account()  # to delete the user account (incl. the datasets)

Note

I couldn't think of a cool name for "UserDataClient". Let me know if you've got anything, I will be glad to change it :)

@liam-sbhoo
Copy link
Collaborator Author

Hey Sam and Noah, please also take a look at this client PR when you have the time. Thanks :)

Copy link
Collaborator

@noahho noahho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Liam, thanks for the great PR!
I couldn't think of a better word for UserDataClient either..
maybe @SamuelGabriel want to look over it as well, but its looking good for me.

tabpfn_client/service_wrapper.py Show resolved Hide resolved
tabpfn_client/service_wrapper.py Show resolved Hide resolved
Copy link
Collaborator

@SamuelGabriel SamuelGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot :) This looks pretty gdpr compliant 😆

I only reviewed it superficially, sorry. Maybe we could talk a bit more in depth about the codebase in our meeting next week.

One general point: I think we should very carefully think about a modularization s.t. we can share a lot of code between local and server TabPFN. But how you did it is fine for now, I think.

tabpfn_client/tabpfn_classifier.py Show resolved Hide resolved
@liam-sbhoo liam-sbhoo merged commit 1740e0a into main Nov 12, 2023
1 check passed
@liam-sbhoo liam-sbhoo deleted the integrate-gdpr-api branch November 12, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants