Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store additional user info #60

Merged
merged 5 commits into from
Jan 5, 2025
Merged

Store additional user info #60

merged 5 commits into from
Jan 5, 2025

Conversation

davidotte
Copy link
Collaborator

Change Description

Try to be precise. You can additionally add comments to your PR, this might help the reviewer a lot.

This PR adds/changes the following things:

  • Ask user for first and last name during registration and send information to the server
  • Move to terms and conditions into registration process
  • User has to agree to PII, send user agreements to the server

If you used new dependencies: Did you add them to requirements.txt?

no new dep

Who did you ping on Mattermost to review your PR? Please ping that person again whenever you are ready for another review.

@noahho

Breaking changes

If you made any breaking changes, please update the version number.
Breaking changes are totally fine, we just need to make sure to keep the users informed and the server in sync.

Does this PR break the API? If so, what is the corresponding server commit?

Yes, see corresponding PR

Does this PR break the user interface? If so, why?


Please do not mark comments/conversations as resolved unless you are the assigned reviewer. This helps maintain clarity during the review process.

@davidotte davidotte requested a review from noahho January 4, 2025 11:19
Copy link
Collaborator

@noahho noahho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Did you check if this will be backwards compatible with old accunts?

tabpfn_client/prompt_agent.py Outdated Show resolved Hide resolved
@davidotte
Copy link
Collaborator Author

For old accounts the first and last name fields in the user table will just be empty. And we of course do not have any user agreements stored for them.

@davidotte davidotte merged commit f407788 into main Jan 5, 2025
2 checks passed
@davidotte davidotte deleted the store-additional-user-info branch January 5, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants