Add Ruff #25
Merged
Add Ruff #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liam-sbhoo
requested changes
Jun 3, 2024
liam-sbhoo
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Brief (a few bullet points describing your changes, use full sentences and try to link lines in the code whenever needed)
Add ruff and pre-commit to client repo (analogous to server repo)
Details (add details if your pull request is more complicated and harder to understand from the code alone)
Standard Qs (leave questions that do not apply blank)
If you broke behavior: Please describe what behavior you broke and how you inform people to not get stuck trying to use the old behavior.
If you used new dependencies: Did you add them to
requirements.txt?yes
Who did you ping on Mattermost to review your PR? Please ping that person again whenever you are ready for another review.
@liam-sbhoo
Please do not mark comments/conversations as resolved unless you are the assigned reviewer. This helps maintain clarity during the review process.