Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to reset password #23

Merged
merged 7 commits into from
May 28, 2024
Merged

Add ability to reset password #23

merged 7 commits into from
May 28, 2024

Conversation

davidotte
Copy link
Collaborator

This PR belongs to this server PR.

When a user tries to login and the login fails, he gets the opportunity to either retry to login or to request a password reset email.

@davidotte davidotte requested a review from SamuelGabriel May 19, 2024 17:56
Copy link
Collaborator

@SamuelGabriel SamuelGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks generally very good. I just tested it locally and added a few changes that I think would help here: #24

I added the message you wanted to have reminding the user of the email, removed the tabpfn dependency.
And one more thing that we should do every time we make breaking changes to the api interface: I update the (min) version number (also on the backend in my PR there) as the interface between client and backend changed. Could you add these changes (merge the branch), then this should be good to go :)

Copy link
Collaborator

@SamuelGabriel SamuelGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidotte davidotte merged commit 689487a into main May 28, 2024
1 check passed
@davidotte davidotte deleted the add-password-reset branch May 28, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants