adds molecule, README to build dependencies #247
Conversation
added FQDN in the tasks Co-authored-by: Beck Davis <[email protected]> Co-authored-by: Denzil Phillips <[email protected]> Co-authored-by: Francis Kayiwa <[email protected]>
…g those tagged 'never' Co-authored-by: Alicia Cozine <[email protected]> Co-authored-by: Beck Davis <[email protected]> Co-authored-by: Francis Kayiwa <[email protected]>
kayiwa
force-pushed
the
i244_build_dependencies
branch
from
34f8176 to
9037e1d
Compare
There was a problem hiding this comment.
I'm not sure how best to review these, is it useful/important to pull down and run molecule locally?
It looks like the build dependencies readme hasn't been filled out, and I see inconsistent licenses in various places (the repo-wide license and our default has been apache 2).
What is the new_role role for?
FYI we have a github actions for molecule tests but I disabled it because they were all failing. I suggest we re-enable it and then you all can update it and add roles to the list as you get them updated.
|
Heya @rlskoeser we are running the tests locally. (there's 3 of us) There's no need - that I see - for you to do this. At some point you will need to, though. I have a ticket to do an introduction to molecule that is still "in the oven"... I will put it in my DevOops repo and give it to y'all |
…ctions Co-authored-by: Beck Davis <[email protected]> Co-authored-by: Francis Kayiwa <[email protected]>
VickieKarasic
force-pushed
the
i244_build_dependencies
branch
from
9037e1d to
3f3c520
Compare
added FQDN in the tasks