WEBNEW-250 👌 Blog QA feedback (round 1) #1930
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This previously wasn't working due to location not being available on a SSR. Instead take the sire url from gatsby query and conjoin to the current blog article slug.
Set as high as 9 meant it was appearing over the mobile nav menu and external widgets eg intercom
Grid was hardcoded to 3 cols/rows so didn't correctly render <3 images in component
Should now appear as h2 style for desktop and h4 style for tablet and below, consistent with deisgns
This was previously 132 but was updated to fix a gap issue. However, it's not an issue with the SVG rather the positioning, so this can be reverted.
Loosened the restrictions in CMS so that image doesn't have to be exactly 16:9. This query ensures that ratio stays at 16:9 instead.
|
Kudos, SonarCloud Quality Gate passed!
|
Gatsby Cloud Build Reportpride-london-web 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 1m PerformanceLighthouse report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks from QA round 1 on new blog area. See Notion/Jira for full rundown of bugs fixed and adjustments made.