Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEBREF-74 ✅ WEBREF-74 Add tests and convert to typescript #1923

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

596050
Copy link
Contributor

@596050 596050 commented Mar 7, 2021

No description provided.

@596050 596050 requested review from egmcdonald and laij84 March 7, 2021 12:16
@596050 596050 requested a review from SonyaMoisset as a code owner March 7, 2021 12:16
@pull-request-size pull-request-size bot added the size/XL Helper label Mar 7, 2021
@596050 596050 added Refactoring Helper and removed size/XL Helper labels Mar 7, 2021
@596050 596050 added this to the Event milestone Mar 7, 2021
@pull-request-size pull-request-size bot added the size/XL Helper label Mar 7, 2021
@596050 596050 force-pushed the WEBREF-74/events-migrate-to-react-testing-library branch from 9cb728e to 7a60d9e Compare March 7, 2021 12:30
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 24 Code Smells

No Coverage information No Coverage information
23.5% 23.5% Duplication

@596050
Copy link
Contributor Author

596050 commented Mar 7, 2021

The quality gate failure seems to be because of mock data and recreating files in typescript which have code quality issues.

@PrideInLondon PrideInLondon deleted a comment from gatsby-cloud bot Mar 7, 2021
@596050 596050 self-assigned this Mar 8, 2021
@SonyaMoisset SonyaMoisset changed the title WEBREF-74 ✅ Add tests and convert to typescript Thomas Price WEBREF-74 ✅ WEBREF-74 Add tests and convert to typescript Mar 10, 2021
@SonyaMoisset SonyaMoisset modified the milestones: Event, Refactoring Mar 10, 2021
@SonyaMoisset SonyaMoisset changed the title Thomas Price WEBREF-74 ✅ WEBREF-74 Add tests and convert to typescript WEBREF-74 ✅ WEBREF-74 Add tests and convert to typescript Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants