Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dockerfile, go.mod and go.sum to allow deployment via docker and automatic dependency downloads #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AnnoyingRain5
Copy link

No description provided.

Copy link
Contributor

@mrjvs mrjvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the pr :)

Some changes are required before this can be merged:

  1. Comment your dockerfile, we need to know whats going on
  2. Use multistage, make one builder, one runner. so that we don't have unused files and dependencies after building, this will also improve runtime
  3. In the steps, install dependencies first, then copy the rest of the source for building
  4. don't use bullseye latest, use a static version of go.

if you are unsure of how this works, read this tutorial: https://dev.to/karanpratapsingh/dockerize-your-go-app-46pp

dockerfile Outdated
EXPOSE 60003/udp
WORKDIR /app
COPY . .
CMD ["go", "run", "."]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a newline at end of file

@mrjvs
Copy link
Contributor

mrjvs commented Sep 3, 2021

@jonbarrow dockerfile tested, all looks good and works properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants