Implement Animal Crossing: Happy Home Designer DataStore protocol #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Phew! All done! |
ItzSwirlz
changed the title
DaniElectra
reviewed
Jun 6, 2024
datastore/ac-happy-home-designer/types/data_store_get_meta_by_owner_id_param.go
Outdated
Show resolved
Hide resolved
datastore/ac-happy-home-designer/types/data_store_get_meta_by_unique_id_param.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel López Guimaraes <[email protected]>
|
As much as we appreicate you taking the time to implement these things, I have mentioned already that none of this work you're doing is going to be used. We no longer wish to have game-specific protocols in this library, opting to implement them on a per-server basis, and removing them from here as that happens. Which means none of this will ever actually see the light of day. I know this was a lot of work, but this is the exact reason why the "approved issues" system was put in place. To avoid people doing work which we won't use/aren't interested in. |
|
Oh, ok... whoops. Well, good practice I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #76
Changes:
Implements Animal Crossing: Happy Home Designer's additional methods to the Data Store protocol.
I have read and agreed to the Code of Conduct.
I have read and complied with the contributing guidelines.
What I'm implementing was an approved issue.
I have tested all of my changes.