Separate moderator logs from event logs #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfendale
reviewed
Aug 5, 2024
jonbarrow
requested changes
Aug 7, 2024
Comment on lines
+26
to
+44
| // * Audit logs will not show up at the same time the message delete event | ||
| await new Promise(resolve => setTimeout(resolve, 1000)); | ||
|
|
||
| const auditLogs = await guild.fetchAuditLogs({ | ||
| type: AuditLogEvent.MessageDelete, | ||
| limit: 5 | ||
| }); | ||
| const auditLogEntry = auditLogs.entries.find(entry => | ||
| entry.target.id === message.author.id && | ||
| entry.extra.channel.id === message.channelId && | ||
| Date.now() - entry.createdTimestamp < 5 * 60 * 1000 | ||
| ); | ||
| // * This large time range is needed because message delete audit log entries are combined if multiple deletions are | ||
| // * performed with the same target user, executor, and channel within 5 minutes. Decreasing this time range would | ||
| // * create a risk of false negatives because the combined entry keeps the timestamp of the first deletion. | ||
| // ! Edge case: If a user deletes their own message after a moderator deletes one of theirs within 5 minutes and in | ||
| // ! the same channel, there will be a false positive mod log entry. | ||
|
|
||
| const isDeletedByModerator = auditLogEntry !== undefined; |
There was a problem hiding this comment.
I do agree with your original message about this not being super great. This looks like it would be very error prone in large servers like ours where tons of messages are deleted all the time. I'm not sure this is worth keeping
There was a problem hiding this comment.
I've gone back and forth on this. I think that it is worth trying out, but if the edge case is hit often enough that it causes a significant amount of confusion, it should be removed. I don't know how common it is for users to delete their own messages within 5 minutes of one of theirs getting deleted by a mod.
MatthewL246
force-pushed
the
mod-logs
branch
2 times, most recently
from
313701f to
dddc818
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #34
Changes:
This creates a setting for a mod-log channel, which will log moderator events like punishments and slow-mode configuration. The event-log channel will continue to log user events like message updates and deletions.
Message deletions?
I originally wanted to move moderator-deleted messages into the mod-logs channel, but there are a few issues with this.
This PR is a draft because a decision on how to handle message deletions has not been made yet.Moderator message deletions have been implemented, with certain pitfalls as noted in a comment.