Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [alert] UT for CTA icon #369

Closed

Conversation

ThbPS
Copy link
Contributor

@ThbPS ThbPS commented Aug 16, 2024

❓ Types of changes

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • πŸ“¦ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Unit test for CTA button icon in alert component
Related to #246

πŸ“ Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@ThbPS ThbPS requested review from ClaraLpresta and mattgoud August 23, 2024 16:34
@mattgoud
Copy link
Collaborator

mattgoud commented Oct 3, 2024

Hello @ThbPS , sorry for the late comment regarding your PR, but there were still design questions about this component and so I suggest you close this PR replaced by #381. Tell me if it suits your needs (i put you reviewer)

@ThbPS ThbPS closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants