Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new-component] sortable list #365

Merged
merged 26 commits into from
Sep 17, 2024
Merged

[new-component] sortable list #365

merged 26 commits into from
Sep 17, 2024

Conversation

mattgoud
Copy link
Collaborator

@mattgoud mattgoud commented Jul 24, 2024 •
edited
Loading

❓ Types of changes

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

New component : Sortable List

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

mattgoud added 10 commits June 25, 2024 13:59
@mattgoud mattgoud linked an issue Jul 24, 2024 that may be closed by this pull request
[Sortable list] create component #364
Closed
3 tasks
@mattgoud mattgoud marked this pull request as ready for review August 1, 2024 07:32
@mattgoud mattgoud requested a review from krimz August 1, 2024 07:32
@mattgoud mattgoud changed the title 42 component sortable list [new-component] sortable list Sep 4, 2024
@mattgoud mattgoud linked an issue Sep 4, 2024 that may be closed by this pull request
[Component] Sortable List #42
Closed
@mattgoud
Copy link
Collaborator Author

mattgoud commented Sep 5, 2024

@guillaume60240 as seen together I assigned you to review the implementation of data tests on this new component. thank you

@mattgoud mattgoud merged commit 7016660 into main Sep 17, 2024
5 checks passed
@mattgoud mattgoud deleted the 42-component-sortable-list branch September 17, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krimz krimz Awaiting requested review from krimz

@guillaume60240 guillaume60240 Awaiting requested review from guillaume60240

Assignees

@guillaume60240 guillaume60240

@mattgoud mattgoud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Sortable list] create component [Component] Sortable List
2 participants
@mattgoud @guillaume60240