Fix logger usage an export (#29)

Fix security alerts
PrestaShopCorp · Sep 14, 2020 · 7b8681b · 7b8681b
1 parent f1f2b20
commit 7b8681b
Show file tree

Hide file tree

Showing 9 changed files with 1,460 additions and 9,215 deletions.
diff --git a/examples/package-lock.json b/examples/package-lock.json
diff --git a/examples/package.json b/examples/package.json
@@ -22,6 +22,8 @@
     "rxjs": "^6.4.0"
   },
   "devDependencies": {
+    "dot-prop": ">=4.2.1",
+    "serialize-javascript": ">=3.1.0",
     "@compodoc/compodoc": "^1.1.11",
     "@types/express": "^4.16.1",
     "@types/node": "^11.9.4",

diff --git a/examples/src/heroes/events/handlers/hero-found-item.handler.ts b/examples/src/heroes/events/handlers/hero-found-item.handler.ts
@@ -6,6 +6,6 @@ import { HeroFoundItemEvent } from '../impl/hero-found-item.event';
 export class HeroFoundItemHandler implements IEventHandler<HeroFoundItemEvent> {
   handle(event: HeroFoundItemEvent) {
     console.log(clc.yellowBright('Async HeroFoundItemEventHandler...'));
-    throw new Error(`Error handling ${event.constructor.name}`);
+    //throw new Error(`Error handling ${event.constructor.name}`);
   }
 }
diff --git a/examples/yarn.lock b/examples/yarn.lock
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "nestjs-geteventstore",
-  "version": "1.3.2",
+  "version": "1.3.4",
   "description": "Event Store connector for Nest js",
   "author": "Taimoor Alam <[email protected]>",
   "contributors": [
@@ -64,7 +64,7 @@
     "@types/jest": "^25.2.1",
     "@types/node": "^12.12.0",
     "@types/supertest": "^2.0.8",
-    "jest": "^25.5.3",
+    "jest": "^26.0.0",
     "prettier": "^1.18.2",
     "supertest": "4.0.2",
     "ts-jest": "^25.4.0",

diff --git a/src/cqrs/event-store-cqrs.module.ts b/src/cqrs/event-store-cqrs.module.ts
@@ -22,10 +22,10 @@ export class EventStoreCqrsModule extends CqrsModule {
       imports: [
         CqrsModule,
         EventBus,
+        Logger,
         EventStoreModule.register(eventStoreConfig),
       ],
       providers: [
-        Logger,
         CommandBus,
         QueryBus,
         EventStorePublisher,
@@ -60,10 +60,10 @@ export class EventStoreCqrsModule extends CqrsModule {
       imports: [
         CqrsModule,
         EventBus,
+        Logger,
         EventStoreModule.registerAsync(eventStoreConfigFactory),
       ],
       providers: [
-        Logger,
         CommandBus,
         QueryBus,
         EventStorePublisher,

diff --git a/src/event-store.module.ts b/src/event-store.module.ts
@@ -16,9 +16,8 @@ export class EventStoreModule {
   static register(config: IEventStoreConfig) {
     return {
       module: EventStoreModule,
-      imports: [],
+      imports: [Logger],
       providers: [
-        Logger,
         {
           provide: EventStore,
           useFactory: logger => {
@@ -52,8 +51,8 @@ export class EventStoreModule {
   static registerAsync(options: EventStoreModuleAsyncOptions): DynamicModule {
     return {
       module: EventStoreModule,
+      imports: [Logger],
       providers: [
-        Logger,
         {
           provide: EventStore,
           useFactory: async (configService, logger) => {

diff --git a/src/interfaces/event-store-config.interface.ts b/src/interfaces/event-store-config.interface.ts
@@ -2,7 +2,6 @@ import { ConnectionSettings, TcpEndPoint } from 'node-eventstore-client';
 import { EventStore } from '../event-store.class';
 import { UserCredentials } from 'geteventstore-promise';
 import { ModuleMetadata } from '@nestjs/common/interfaces';
-import { IEventStoreBusConfig } from './event-store-bus-config.interface';
 
 export interface IHttpEndpoint extends TcpEndPoint {}