Custom prestashop release #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Alexandre-Lematre
commented
Apr 18, 2024
•
Alexandre-Lematre
commented
| Questions | Answers |
|---|---|
| Description? | Adds the ability to build a release based on a custom prestashop zip containing a list of modules |
| Type? | new feature |
| BC breaks? | no |
| Deprecations? | no |
| Sponsor company | PrestaShop |
| How to test? | Try to build a release with the PrestaShop Classic Edition zip |
jokesterfr
reviewed
Apr 19, 2024
jokesterfr
reviewed
Apr 19, 2024
jokesterfr
reviewed
Apr 19, 2024
build.sh
Outdated
| declare PLATFORM; # -- alias for $TARGET_PLATFORM | ||
| declare TARGET_IMAGE; # -- docker image name, defaults to "prestashop/prestashop-flashlight" | ||
| declare PUSH; # -- set it to "true" if you want to push the resulting image | ||
| declare ZIP_SOURCE; # -- the zip to unpack in flashlight |
There was a problem hiding this comment.
We do actually have an open PR on this one! Can we merge ideas?
There was a problem hiding this comment.
Sure. Can you tell me what PR is this ? I can't find it
There was a problem hiding this comment.
Was thinking about that one : #82
Alexandre-Lematre
force-pushed
the
feat/classic-edition
branch
2 times, most recently
from
46f0830
to
9e081f4
Compare
jokesterfr
reviewed
May 14, 2024
build.sh
Outdated
| declare TARGET_IMAGE; # -- docker image name, defaults to "prestashop/prestashop-flashlight" | ||
| declare PUSH; # -- set it to "true" if you want to push the resulting image | ||
| declare ZIP_SOURCE; # -- the zip to unpack in flashlight | ||
| declare PRE_INSTALLED_MODULES; # -- install modules during zip installation |
There was a problem hiding this comment.
I don't think this should come along with the build time. It's rather a variable to be declared on top of assets/run.sh
jokesterfr
reviewed
May 14, 2024
docker/alpine.Dockerfile
Outdated
| @@ -47,6 +48,8 @@ ARG PHP_VERSION | |||
| ARG GIT_SHA | |||
| ARG PS_FOLDER=/var/www/html | |||
| ARG ZIP_SOURCE | |||
| ARG PRE_INSTALLED_MODULES | |||
| ENV PRE_INSTALLED_MODULES=$PRE_INSTALLED_MODULES | |||
There was a problem hiding this comment.
is it really something you wanna provide at build time?
There was a problem hiding this comment.
These modules have to be installed during PrestaShop installation, so, at build time ; the aim being to provide a custom release, shiped with a bunch of modules (like classic and hosted edition)
Alexandre-Lematre
force-pushed
the
feat/classic-edition
branch
from
9e081f4
to
feb5333
Compare
Alexandre-Lematre
force-pushed
the
feat/classic-edition
branch
from
feb5333
to
62b6e9a
Compare
Alexandre-Lematre
force-pushed
the
feat/classic-edition
branch
from
62b6e9a
to
d087d1a
Compare
Alexandre-Lematre
force-pushed
the
feat/classic-edition
branch
from
d087d1a
to
96f07fc
Compare
Alexandre-Lematre
force-pushed
the
feat/classic-edition
branch
from
96f07fc
to
4332f39
Compare
Alexandre-Lematre
force-pushed
the
feat/classic-edition
branch
from
4332f39
to
fff17fe
Compare
Alexandre-Lematre
force-pushed
the
feat/classic-edition
branch
from
fff17fe
to
8049560
Compare
jokesterfr
reviewed
Nov 18, 2024
jokesterfr
reviewed
Nov 18, 2024
jokesterfr
reviewed
Nov 18, 2024
jokesterfr
reviewed
Nov 18, 2024
jokesterfr
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.