-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split shop building in independent single job for optimization #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I love this, did you start a test somewhere ? |
@boubkerbribri yep one of the tests https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/5891548178 but it's not working yet I'm still experiencing |
mflasquin
approved these changes
Aug 21, 2023
M0rgan01
reviewed
Aug 21, 2023
jolelievre
force-pushed
the
split-jobs
branch
13 times, most recently
from
August 25, 2023 00:47
9d3027e
to
f0a07a4
Compare
jolelievre
force-pushed
the
split-jobs
branch
2 times, most recently
from
September 13, 2023 22:46
5e2180c
to
5a0c1b0
Compare
jolelievre
force-pushed
the
split-jobs
branch
6 times, most recently
from
September 14, 2023 01:30
ed3281a
to
75b399a
Compare
jolelievre
force-pushed
the
split-jobs
branch
from
September 20, 2023 10:08
b3412c2
to
3bf6bdb
Compare
jolelievre
changed the title
Split docker building in independent single job for optimization
Split shop building in independent single job for optimization
Sep 22, 2023
boubkerbribri
approved these changes
Sep 25, 2023
Progi1984
approved these changes
Sep 25, 2023
Great job @jolelievre and thank you @Progi1984 and @boubkerbribri for the extensive review work |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes with a related one in the core PrestaShop/PrestaShop#33690 Not required but it allows optimizing a bit more the test phase (no need to install composer and node in the docker during the second test phase since everything has already been installed and built)
The workflow itself has multiple optimizations:
New features:
Remaining possible improvement
Benchmark
Using the optimized PR PrestaShop/PrestaShop#33690
Only this benchmark was run without another build in parallel for the sake of showing the improvement
With the split workflow
Without cache
https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/6207662484
Total duration: 31m 5s
Total run time: 7h 20m 47s
With cache already set
https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/6208145339
Total duration: 31m 18s
Total run time: 7h 1m 43s
Note
In both cases sanity tests are fixed
With the split framework but less cache management
Without cache
https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/6278375332
With cache already set
https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/6276944907
Total duration: 33m 30s
Total run time: 7h 18m 49s
Without the split workflow
No cache system
https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/6208570595
Total duration: 54m 49s
Total run time: 10h 30m 48s
Warning
Sanity tests failing, which makes the total duration longer because failing tests are long to finish
Other PRs
Merge PR
PrestaShop/PrestaShop#33952
https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/6208800734
PR to update doctrine that failed sanity tests
PrestaShop/PrestaShop#33459
https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/6226478282
PR targeting 8.1.x
PrestaShop/PrestaShop#33930
Split jobs
https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/6226487438
No split jobs
https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/6222099607
PR that updates ps_linklist
PrestaShop/PrestaShop#33853
Split jobs
https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/6208823720
No split jobs
https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/6222085952