-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow .well-known directory (pki validation / letsencrypt) #1724
Allow .well-known directory (pki validation / letsencrypt) #1724
Conversation
BarbUk
commented
Sep 9, 2023
Questions | Answers |
---|---|
Branch? | 8.x |
Description? | Fix nginx example configuration to allow .well-known directory usage, which is used for pki validation or acme / letsencrypt |
Fixed ticket? | no |
The same modification should be done to the 1.7 branch. |
Usually we first merge the PR on 8.x then we create another PR and use |
Hi there! Don't get me wrong, this improvement could be provided as a secondary integration example, but you never know the will of the user integrating nginx + prestashop. Use cases are very wide, it could be placed behind another reverse-proxy taking care of the HTTPS, or any other http component... Better not document (and maintain) what is not closely relevant to PrestaShop IMO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a NGINX expert but I trust @jokesterfr on this topic 👍
The developer documentation of PrestaShop must act as a standard guide for prestashop newcomers so we can only add in it generic and standard information, we can't push side-cases
Letsencrypt is one of the many services that use a well-known dir. Usage of this resource is documented in RFC 8615. You document a configuration that explicitly deny usage of this directory. It should not be blocked by default IMHO. |
Hi @BarbUk, i suggest moving your example to: https://devdocs.prestashop-project.org/8/scale/webservers/nginx/
You could create a heading and show your code snippet 👍 |
Great suggestion from @thomasnares |
Thanks for the suggestion @thomasnares. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BarbUk, i just added some majs on the brands/services
thank you @BarbUk ! |