Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from Slim to Symfony #78

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Migrate from Slim to Symfony #78

merged 3 commits into from
Jan 4, 2024

Conversation

Progi1984
Copy link
Member

Questions Answers
Description? Migrate from Slim to Symfony
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? N/A
Sponsor company @PrestaShopCorp
How to test? N/A

@Progi1984 Progi1984 force-pushed the migrationSymfony branch 2 times, most recently from 5ea9cda to a1bec69 Compare January 3, 2024 14:28
@Progi1984 Progi1984 force-pushed the migrationSymfony branch 4 times, most recently from 528e737 to 13f1d9c Compare January 3, 2024 15:26
jolelievre
jolelievre reviewed Jan 3, 2024
View reviewed changes
.env Outdated Show resolved Hide resolved
.env Outdated Show resolved Hide resolved
.env.test Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
bin/console Show resolved Hide resolved
src/Entity/Test.php Outdated Show resolved Hide resolved
src/Entity/Test.php Show resolved Hide resolved
src/Service/ReportSuiteBuilder.php Show resolved Hide resolved
symfony.lock Show resolved Hide resolved
tests/Controller/DataControllerTest.php Show resolved Hide resolved
@Progi1984
Copy link
Member Author

@jolelievre & @matthieu-rolland CI is always 🟢

image

@Progi1984 Progi1984 requested a review from jolelievre January 4, 2024 10:05
@jolelievre jolelievre merged commit a0ad813 into PrestaShop:develop Jan 4, 2024
2 checks passed
@Progi1984 Progi1984 deleted the migrationSymfony branch January 4, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolelievre jolelievre jolelievre approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

@nicosomb nicosomb Awaiting requested review from nicosomb

@boubkerbribri boubkerbribri Awaiting requested review from boubkerbribri

Assignees
No one assigned
Labels
Waiting for QA
Projects
PR Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Progi1984 @matthieu-rolland @jolelievre @ps-jarvis