forked from codedge-llc/pigeon
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLACEHOLDER PR for internal review #1
Open
petermueller
wants to merge
4
commits into
master
Choose a base branch
from
pkm/support-gcp-default-application-credentials
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
PLACEHOLDER PR for internal review #1
petermueller
wants to merge
4
commits into
master
from
pkm/support-gcp-default-application-credentials
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErinLMoore
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮
petermueller
pushed a commit
that referenced
this pull request
Apr 1, 2024
* fix: move token generation to agent (#1) * fix: add uri to token storage key to prevent clashes (codedge-llc#2) * Catch up with upstream (codedge-llc#3) * fix: allow httpoison 2.0 (codedge-llc#236) * fix: allow httpoison 2.0 * ci: fix workflows * ci: revert to ubuntu-latest * ci: use setup-beam@v1 * chore: update CHANGELOG * docs: update README links * fix: move token generation into Pigeon.APNS.Token (codedge-llc#227) This means the token is only generated once and used across all workers * chore: update CHANGELOG --------- Co-authored-by: Henry Popp <[email protected]> Co-authored-by: Henry Popp <[email protected]> Co-authored-by: Andrew Timberlake <[email protected]> * chore: run mix format on our changes (codedge-llc#4) * fix: allow httpoison 2.0 (codedge-llc#236) * fix: allow httpoison 2.0 * ci: fix workflows * ci: revert to ubuntu-latest * ci: use setup-beam@v1 * chore: update CHANGELOG * docs: update README links * fix: move token generation into Pigeon.APNS.Token (codedge-llc#227) This means the token is only generated once and used across all workers * chore: update CHANGELOG --------- Co-authored-by: Henry Popp <[email protected]> Co-authored-by: Henry Popp <[email protected]> Co-authored-by: Andrew Timberlake <[email protected]> * chore: undo random formatting changes that aren't necessary --------- Co-authored-by: Drew Ballance <[email protected]> Co-authored-by: Henry Popp <[email protected]> Co-authored-by: Henry Popp <[email protected]> Co-authored-by: Andrew Timberlake <[email protected]>
petermueller
force-pushed
the
pkm/support-gcp-default-application-credentials
branch
from
April 1, 2024 02:35
dbb0da5
to
e721c10
Compare
- add `PigeonTest.GothHttpClient.Stub` to docs - add example usage of `PigeonTest.GothHttpClient.Stub` to module docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see codedge-llc#235 for library's PR
This is a public repository though, as a heads up.