Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove import dregs from client #16604

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Remove import dregs from client #16604

merged 4 commits into from
Jan 6, 2025

Conversation

aaazzam
Copy link
Collaborator

@aaazzam aaazzam commented Jan 3, 2025

In #16587 some block imports were left in the main client, this PR removes them

Copy link

codspeed-hq bot commented Jan 3, 2025

CodSpeed Performance Report

Merging #16604 will not alter performance

Comparing remove-block-dregs (115f641) with main (9461ae0)

Summary

✅ 3 untouched benchmarks

@aaazzam aaazzam enabled auto-merge (squash) January 4, 2025 04:10
Comment on lines 54 to 56
import sys

print(f"URL: {response.url}", file=sys.stderr)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this leftover from debugging?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure is

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed in 115f641

@aaazzam aaazzam merged commit f6a039f into main Jan 6, 2025
38 checks passed
@aaazzam aaazzam deleted the remove-block-dregs branch January 6, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants