Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup a few refs #16586

Merged
merged 5 commits into from
Jan 3, 2025
Merged

cleanup a few refs #16586

merged 5 commits into from
Jan 3, 2025

Conversation

aaazzam
Copy link
Collaborator

@aaazzam aaazzam commented Jan 3, 2025

In refactoring the Prefect client, two "heavy" refs slipped by:

  • prefect.states.Scheduled which imports all its friends and inflates memory
  • prefect.client.schemas.sorting enums. Enums suck here, because you have to import them in order to set defaults, but since our imports are a little wonky to begin with, you end up importing every model just to set a default. So the one place this is used (which is inconsistent with other methods anyway) in logs, the sort is now optional and the default logic is moved inside the body of the function.

Copy link

codspeed-hq bot commented Jan 3, 2025

CodSpeed Performance Report

Merging #16586 will not alter performance

Comparing rm-heavy-refs (2469e5d) with main (488e7b4)

Summary

✅ 3 untouched benchmarks

@aaazzam aaazzam merged commit 89aa0e7 into main Jan 3, 2025
38 checks passed
@aaazzam aaazzam deleted the rm-heavy-refs branch January 3, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants