Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI v2] feat: Adds AutomationsActionsMenu component #16575

Merged
merged 1 commit into from
Jan 3, 2025
Merged

[UI v2] feat: Adds AutomationsActionsMenu component #16575

merged 1 commit into from
Jan 3, 2025

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Jan 2, 2025 •
edited
Loading

  1. Adds AutomationsActionsMenu component. Opting out from writing a test for this for now because there's a Link component dependency
  2. Re-organizes DocsLink component to resolve eslint hotload warning from constants
  3. Exposes DOCS_LINKS constant to the webapp
  4. Adds /automations/automation/:id/edit route

Screenshot 2025-01-02 at 12 11 41 PM

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Jan 2, 2025
@devinvillarosa devinvillarosa marked this pull request as ready for review January 2, 2025 20:17
@devinvillarosa devinvillarosa force-pushed the automations-actions-menu branch from 81f6389 to b9dd86f Compare January 3, 2025 04:10
desertaxle
desertaxle approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devinvillarosa devinvillarosa merged commit 7a6d699 into main Jan 3, 2025
8 checks passed
@devinvillarosa devinvillarosa deleted the automations-actions-menu branch January 3, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desertaxle desertaxle desertaxle approved these changes

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@zzstoatzz zzstoatzz Awaiting requested review from zzstoatzz zzstoatzz is a code owner

Assignees
No one assigned
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinvillarosa @desertaxle