Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI v2] fix: Create consistent concurrency limit nav title #16559

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Dec 31, 2024

  1. Updates Concurrency Title to use Breadcrumb component (to be consistent with Variables and Deployments page).
  2. Updates nav button to not span across the entire page.
Screen.Recording.2024-12-31.at.9.57.52.AM.mov

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Dec 31, 2024
@devinvillarosa devinvillarosa marked this pull request as ready for review December 31, 2024 18:12
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It looks like we may also want to decrease the size of the global and task run concurrency limit subheaders.

@devinvillarosa devinvillarosa force-pushed the fix-concurrency-header branch 2 times, most recently from ac69ebf to f798a6d Compare January 2, 2025 18:27
@devinvillarosa devinvillarosa force-pushed the fix-concurrency-header branch from f798a6d to d0da07f Compare January 2, 2025 18:32
@devinvillarosa devinvillarosa merged commit 50dfa9a into main Jan 2, 2025
5 checks passed
@devinvillarosa devinvillarosa deleted the fix-concurrency-header branch January 2, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants