Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[typing] prefect._internal, prefect.server.utilities #16497

Merged
merged 1 commit into from
Dec 26, 2024
Merged

[typing] prefect._internal, prefect.server.utilities #16497

merged 1 commit into from
Dec 26, 2024

Conversation

mjpieters
Copy link
Contributor

@mjpieters mjpieters commented Dec 24, 2024 •
edited
Loading

References #16292

@mjpieters mjpieters force-pushed the typing_prefect__internal branch from aa3ef6f to 62d7ba8 Compare December 24, 2024 23:40
@github-actions github-actions bot added the development Tech debt, refactors, CI, tests, and other related work. label Dec 24, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 24, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #16497 will not alter performance

Comparing mjpieters:typing_prefect__internal (7162fb7) with main (bafed7c)

Summary

✅ 3 untouched benchmarks

@mjpieters mjpieters changed the title [typing] p._internal, p.server.utilities [typing] prefect._internal, prefect.server.utilities Dec 25, 2024
@mjpieters mjpieters force-pushed the typing_prefect__internal branch from 62d7ba8 to bcb3d12 Compare December 25, 2024 09:51
@mjpieters mjpieters force-pushed the typing_prefect__internal branch from bcb3d12 to 7162fb7 Compare December 26, 2024 15:26
@mjpieters
Copy link
Contributor Author

This PR improves type compleness by 0.32%. A small amount but enough to push the total over 80%.

I'm working on a tool to make finding areas to work on next, easier. Stay tuned!

prefect

@desertaxle
Copy link
Member

I'm working on a tool to make finding areas to work on next, easier. Stay tuned!

That's a really cool visualization!

desertaxle
desertaxle approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@desertaxle desertaxle merged commit 4386cb5 into PrefectHQ:main Dec 26, 2024
38 checks passed
@mjpieters mjpieters deleted the typing_prefect__internal branch December 26, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desertaxle desertaxle desertaxle approved these changes

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@zzstoatzz zzstoatzz Awaiting requested review from zzstoatzz zzstoatzz is a code owner

Assignees
No one assigned
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjpieters @desertaxle