[typing] misc prefect modules #16468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjpieters
requested review from
cicdw,
desertaxle and
zzstoatzz
as code owners
github-actions
bot
added
the
development
mjpieters
force-pushed
the
typing_prefect_misc
branch
from
2b1ba99 to
fe252fc
Compare
CodSpeed Performance ReportMerging #16468 will not alter performanceComparing Summary
|
mjpieters
commented
Dec 20, 2024
Comment on lines
-233
to
-265
| @inject_client | ||
| async def _create_artifact( | ||
| type: str, | ||
| key: Optional[str] = None, | ||
| description: Optional[str] = None, | ||
| data: Optional[Union[Dict[str, Any], Any]] = None, | ||
| client: Optional["PrefectClient"] = None, | ||
| ) -> UUID: | ||
| """ | ||
| Helper function to create an artifact. | ||
|
|
||
| Arguments: | ||
| type: A string identifying the type of artifact. | ||
| key: A user-provided string identifier. | ||
| The key must only contain lowercase letters, numbers, and dashes. | ||
| description: A user-specified description of the artifact. | ||
| data: A JSON payload that allows for a result to be retrieved. | ||
| client: The PrefectClient | ||
|
|
||
| Returns: | ||
| - The table artifact ID. | ||
| """ | ||
|
|
||
| artifact = await Artifact( | ||
| type=type, | ||
| key=key, | ||
| description=description, | ||
| data=data, | ||
| ).create(client) | ||
|
|
||
| return artifact.id | ||
|
|
||
|
|
There was a problem hiding this comment.
This method has been unused since the last reference to it was removed in 8577a34.
mjpieters
force-pushed
the
typing_prefect_misc
branch
18 times, most recently
from
8981f2a to
a6fc0d4
Compare
A few more modules to pass strict typing checks.
mjpieters
force-pushed
the
typing_prefect_misc
branch
from
a6fc0d4 to
3786aa5
Compare
github-actions
bot
added
the
upstream dependency
devinvillarosa
pushed a commit
that referenced
this pull request
Dec 24, 2024
devinvillarosa
pushed a commit
that referenced
this pull request
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few more modules to pass strict typing checks.
References #16292