Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor prefect.flow decorator #16405

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

mjpieters
Copy link
Contributor

This makes the flow.from_source() callable available to the type checker.

A new tests/typesafety suite provides coverage for the type annotations here.

Related: #16292

@github-actions github-actions bot added the upstream dependency An upstream issue caused by a bug in one of our dependencies label Dec 16, 2024
Copy link

codspeed-hq bot commented Dec 16, 2024

CodSpeed Performance Report

Merging #16405 will not alter performance

Comparing mjpieters:prefect_flow_from_source (dad7ff5) with main (a0248c7)

Summary

✅ 3 untouched benchmarks

@mjpieters mjpieters force-pushed the prefect_flow_from_source branch 15 times, most recently from c65e5ed to 0aa4322 Compare December 18, 2024 18:36
@mjpieters
Copy link
Contributor Author

The 3 test failures here are due to #16440

@mjpieters mjpieters force-pushed the prefect_flow_from_source branch 9 times, most recently from 09ed111 to 65963a3 Compare December 19, 2024 23:18
@mjpieters mjpieters force-pushed the prefect_flow_from_source branch from 65963a3 to 549773c Compare December 19, 2024 23:56
This makes the `flow.from_source()` callable available to the type checker.

A new tests/typesafety suite provides coverage for the type annotations here.
@mjpieters mjpieters force-pushed the prefect_flow_from_source branch from 549773c to dad7ff5 Compare December 20, 2024 00:44
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@desertaxle desertaxle merged commit dc79adc into PrefectHQ:main Dec 20, 2024
44 checks passed
@mjpieters mjpieters deleted the prefect_flow_from_source branch December 20, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream dependency An upstream issue caused by a bug in one of our dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants