[typing] update prefect.futures
#16381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #16381 will not alter performanceComparing Summary
|
zzstoatzz
added
the
development
zzstoatzz
changed the title
prefect.futuresprefect.futures
zzstoatzz
force-pushed
the
fix-wait-typing
branch
from
6a047a1 to
74094f9
Compare
zzstoatzz
force-pushed
the
fix-wait-typing
branch
from
74094f9 to
bbb393b
Compare
mjpieters
reviewed
Dec 21, 2024
| try: | ||
| with timeout_context(timeout): | ||
| done = {f for f in unique_futures if f._final_state} | ||
| done = {f for f in unique_futures if f._final_state} # type: ignore[privateUsage] |
There was a problem hiding this comment.
Perhaps the PrefectFuture class should have a public read-only property or method for this? Also, I find getattr() helpful to hide private access from the type checker 😇
|
|
||
| def _collect_futures(futures, expr, context): | ||
| def _collect_futures( | ||
| futures: set[PrefectFuture[R]], expr: Any, context: Any |
There was a problem hiding this comment.
context must at least support .get(str) so I think it should be a Mapping[str, Any], certainly given what I've seen of how contexts are used in perfect. Ditto in other argument annotations below.
| @@ -455,14 +470,14 @@ def _collect_futures(futures, expr, context): | |||
| return expr | |||
|
|
|||
| # Get final states for each future | |||
| states = [] | |||
| states: list[State] = [] | |||
There was a problem hiding this comment.
State is generic, so this is missing a parameter.
Suggested change
| states: list[State] = [] | |
| states: list[State[Any]] = [] |
devinvillarosa
pushed a commit
that referenced
this pull request
Dec 24, 2024
devinvillarosa
pushed a commit
that referenced
this pull request
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #16292
updates typing of wait and
DoneAndNotDoneFutures