Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sync_compatible from build_server #16314

Merged
merged 6 commits into from
Dec 10, 2024

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Dec 10, 2024

related to #15008

also updates typing in prefect.flows and prefect.transactions to satisfy the type completeness check

@github-actions github-actions bot added the enhancement An improvement of an existing feature label Dec 10, 2024
Copy link

codspeed-hq bot commented Dec 10, 2024

CodSpeed Performance Report

Merging #16314 will not alter performance

Comparing remove-sync-compat-runner-webserver (e14a811) with main (612106c)

Summary

✅ 3 untouched benchmarks

@zzstoatzz zzstoatzz added the development Tech debt, refactors, CI, tests, and other related work. label Dec 10, 2024
@zzstoatzz zzstoatzz self-assigned this Dec 10, 2024
Comment on lines +109 to +111
StateHookCallable: TypeAlias = Callable[
[FlowSchema, FlowRun, State], Union[Awaitable[None], None]
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧼

@zzstoatzz zzstoatzz merged commit f30b353 into main Dec 10, 2024
40 checks passed
@zzstoatzz zzstoatzz deleted the remove-sync-compat-runner-webserver branch December 10, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Tech debt, refactors, CI, tests, and other related work. enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants