Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused function in results.py #14744

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Remove unused function in results.py #14744

merged 1 commit into from
Jul 24, 2024

Conversation

seanpwlms
Copy link
Contributor

It looks like _get_or_create_default_storage is not invoked anywhere, so this PR removes it.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

@seanpwlms seanpwlms requested a review from cicdw as a code owner July 24, 2024 18:45
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love a good cleanup - thank you @seanpwlms !

@cicdw cicdw added the development Tech debt, refactors, CI, tests, and other related work. label Jul 24, 2024
Copy link

codspeed-hq bot commented Jul 24, 2024

CodSpeed Performance Report

Merging #14744 will not alter performance

Comparing remove_unused_function (b7b5eae) with main (e2832e2)

Summary

✅ 5 untouched benchmarks

@cicdw cicdw merged commit e430486 into main Jul 24, 2024
34 of 35 checks passed
@cicdw cicdw deleted the remove_unused_function branch July 24, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants