-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix task key computation #14704
Fix task key computation #14704
Conversation
CodSpeed Performance ReportMerging #14704 will degrade performances by 11.46%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion to move more logic into your utility function
2d3b1c4
to
f8438c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
7c6efc9
to
a63c9bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and the Codspeed tests are still new so we can merge without forcing that one benchmark to pass right now, especially given the variance and how tiny the "slowdown" is.
closes #13735
this PR removes our reliance on the absolute path of the source file, which caused persistent cache misses due to source code being cloned to tmp dirs
the original issue was reported on a 2.x version - if this looks good I can backport this to
2.x