-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adds metrics for client-side event emission and subscription
Following the addition of the `prometheus_client` in #14783, this adds counters for measuring the performance of Prefect event emissions and subscription. A note about unit tests: I don't traditionally add unit tests for "leaf-level" instrumentation like this. Leaf-level here means it is measuring something about the system and doesn't form part of a measurement API (like if there were middleware for measuring HTTP latency, for example). Unless it is particularly complex to calculate, I generally skip extra unit tests and let the standard test suite and coverage inform me if the instrumentation might be a problem or not executed.
- Loading branch information
1 parent
9a4c901
commit 79fed45
Showing
1 changed file
with
54 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters