-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: FlowList
and DeploymentList
components
#1346
Feature: FlowList
and DeploymentList
components
#1346
Conversation
@brandonreid fixed the border radius issue; I'm not against an icon per-se but I also don't want to shoe-horn them into this design when we're not using them for top-level items anywhere else. |
Also this PR is missing commits atm cause of the ongoing github issues - some of the fixes won't yet be applied |
Ok looks like all commits are showing up and should be in the demo now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for so many comments. There's a lot here that's really good. And I love the direction. Just wanting to really iron this out since its a significant rewrite.
So I went ahead and wrote All other feedback has also been addressed 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for working through all the details with me!
This PR:
New:
FlowList
component; functionally equivalent to theFlowsTable
FlowListItem
component; functionally equivalent to a row in theFlowTable
except contains a list of its deployments, used inFlowList
DeploymentList
component; functionally equivalent to theDeploymentsTable
, used inFlowListItem
DeploymentListItem
component, functionally equivalent to a row in theDeploymentsTable
, used inFlowListItemDeployments
lastFlowRun
composition; creates a subscription for the most recent flow run (by expected start time) matching the passed filter and returns aComputedRef
for the run and the subscription itselfnextFlowRun
composition; creates a subscription for the next flow run (by expected start time) matching the passed filter and returns aComputedRef
for the run and the subscription itselfEnhanced:
StateListItem
component now supports anaction
slot, along with several other enhancements (non-breaking, should all be purely additive)Fixed: