Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actually ignore extra #1018

Merged
merged 4 commits into from
Jan 18, 2025
Merged

actually ignore extra #1018

merged 4 commits into from
Jan 18, 2025

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Jan 18, 2025 •
edited
Loading

handles the db url w/o dict access and avoiding the recursion

@jlowin are you cool if I add some pre-commit to catch dict instead of dict[str, Any] etc?

@github-actions github-actions bot added the feature Pull requests that add features label Jan 18, 2025
@jlowin
Copy link
Member

jlowin commented Jan 18, 2025

Sure!

@zzstoatzz zzstoatzz force-pushed the ignore-extra-settings branch from 9099b55 to 50a0b2d Compare January 18, 2025 01:12
@zzstoatzz zzstoatzz merged commit 8755ae3 into marvin-3 Jan 18, 2025
3 checks passed
@zzstoatzz zzstoatzz deleted the ignore-extra-settings branch January 18, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowin jlowin jlowin approved these changes

Assignees
No one assigned
Labels
feature Pull requests that add features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zzstoatzz @jlowin