Chore/create run #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jimid27
commented
Jan 2, 2024
•
jimid27
commented
- Relates: https://github.com/PrefectHQ/platform/issues/5625
- Creates shareable GHA for updatecli runs since major and minor are identical just with different manifests and schedules
- Example run: https://github.com/PrefectHQ/flows/actions/runs/7391218314/job/20107588255
parkedwards
reviewed
Jan 2, 2024
Co-authored-by: Edward Park <[email protected]>
parkedwards
reviewed
Jan 2, 2024
action.yaml
Outdated
| git commit -m "dependency-version-${{ inputs.run-type }}-${{ steps.date.outputs.date }}" | ||
| git push --set-upstream origin "dependency-version-${{ inputs.run-type }}-${{ steps.date.outputs.date }}" | ||
| env: | ||
| GITHUB_TOKEN: ${{ github.token }} |
There was a problem hiding this comment.
does this need to be passed in as an action var? i forget if custom actions have access to the workflow's token scope
There was a problem hiding this comment.
lemme verify you may be right there
There was a problem hiding this comment.
https://docs.github.com/en/actions/security-guides/automatic-token-authentication#example-1-passing-the-github_token-as-an-input passing like this example. May be unnecessary but worth it to be confident the right perms are passing
parkedwards
approved these changes
Jan 2, 2024
…ecli-minor-run into chore/create-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.