chore/Add release script and update gha to pull the latest release vs tag #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jimid27
commented
Dec 5, 2024
jimid27
commented
- Resolves: https://linear.app/prefect/issue/PLA-800/actions-prefect-deploy-add-release-script-to-automatically-bump-the
- Updates GHA to not set the major version of the release (i.e v4) as the "latest" release as we use releases to determine version bumps. Also generally it seems that other GHA use the minor/patches as the latest releases
- Creates a release script similar to our other release scripts but bumps the semver version based on user input of major, minor, or patch. I'm happy to separate these into individual functions similar to our other scripts but it didn't feel overly necessary here.
parkedwards
reviewed
Dec 5, 2024
| @@ -0,0 +1,46 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
when/how does this script get run
There was a problem hiding this comment.
locally similar to what we do for cloud releases
jimid27
commented
Dec 5, 2024
| @@ -26,7 +26,7 @@ jobs: | |||
| else | |||
| echo "Tag ${MAJOR_VERSION} does not exist. Creating a new tag and release." | |||
| export RELEASE_SHA=$(git rev-parse HEAD) | |||
| gh release create "${MAJOR_VERSION}" --title "${MAJOR_VERSION}" --generate-notes --target "${RELEASE_SHA}" --latest | |||
| gh release create "${MAJOR_VERSION}" --title "${MAJOR_VERSION}" --generate-notes --target "${RELEASE_SHA}" --latest=false | |||
There was a problem hiding this comment.
Setting latest to false so that the latest semver release is known to be the latest
jamiezieziula
approved these changes
Dec 5, 2024
parkedwards
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.