Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Youtube): channel name & image being null #8883

Merged
merged 4 commits into from
Nov 15, 2024
Merged

fix(Youtube): channel name & image being null #8883

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
96206b0
fix(Youtube): channel name being null
darkvillager2 Nov 12, 2024
893e4c6
fix(Youtube): version bump
darkvillager2 Nov 12, 2024
207b7ca
fix(Youtube): fix channel logo"
darkvillager2 Nov 12, 2024
fb3c2c0
Update presence.ts
darkvillager2 Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion websites/Y/YouTube/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"www.youtube.com",
"studio.youtube.com"
],
"version": "5.13.3",
"version": "5.13.4",
"logo": "https://cdn.rcd.gg/PreMiD/websites/Y/YouTube/assets/logo.png",
"thumbnail": "https://cdn.rcd.gg/PreMiD/websites/Y/YouTube/assets/thumbnail.jpg",
"color": "#E40813",
Expand Down
9 changes: 7 additions & 2 deletions websites/Y/YouTube/presence.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,8 @@ presence.on("UpdateData", async () => {
!document.querySelector("#text.ytd-channel-name")?.textContent &&
documentTitle.includes(
document.querySelector("#text.ytd-channel-name")?.textContent
)
) &&
document.querySelector("#text.ytd-channel-name")?.textContent
darkvillager2 marked this conversation as resolved.
Show resolved Hide resolved
)
user = document.querySelector("#text.ytd-channel-name").textContent;
// Get channel name from website's title
Expand Down Expand Up @@ -399,7 +400,11 @@ presence.on("UpdateData", async () => {
// When viewing a community post
document.querySelector<HTMLImageElement>(
"#author-thumbnail > a > yt-img-shadow > img"
)
) ??
// When viewing a channel on the normal channel page
document
.querySelector(".yt-spec-avatar-shape")
?.querySelector("img")
)?.src.replace(/=s[0-9]+/, "=s512") ?? YouTubeAssets.Logo;
if (channelImg) presenceData.largeImageKey = channelImg;
}
Expand Down
Loading