Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(YTPLR): fix iframe has already been declared #8842

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

PeterStrick
Copy link
Contributor

Description

This PR fixes an Error only present on PreMiD 2.6.12 (and likely older Versions?) that is not present on either Alpha or Beta Versions of PreMiD 2.7.x

Said Error being Uncaught SyntaxError: Identifier 'iframe' has already been declared (at iframe.js:1:1)

Acknowledgements

Screenshots

Error Screenshot

image

@darkvillager2
Copy link
Contributor

darkvillager2 commented Oct 28, 2024

@PeterStrick that issue can be ignored and doesnt need to be solved. Iirc

@PeterStrick
Copy link
Contributor Author

@PeterStrick that issue can be ignored and doesnt need to be solved. Iirc

Problem being though as far as I could test, the Presence does not work on Stable PreMiD if the variable isn't renamed which is weird

@Bas950 Bas950 enabled auto-merge (squash) November 4, 2024 07:44
Copy link
Member

@Timeraa Timeraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a weird issue with the stable version that only happens on certain cases so this is fine

@Bas950 Bas950 merged commit 9d0b118 into PreMiD:main Nov 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants