feat(Anime Sama): add privacy mode and update timestamps #8839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Signed-off-by: Skully <[email protected]>
theusaf
reviewed
Oct 28, 2024
Comment on lines
+5
to
13
| "name": "Atom Skully", | ||
| "id": "671037171611729920" | ||
| }, | ||
| "contributors": [ | ||
| { | ||
| "name": "Atom Skully", | ||
| "id": "671037171611729920" | ||
| "name": "RisingSunLight", | ||
| "id": "240521747852558347" | ||
| } | ||
| ], |
There was a problem hiding this comment.
Is there a reason you are swapping the contributor and author field?
There was a problem hiding this comment.
I think it's best, as this is the second time I've modified/added features to this Presence.
What's more, the original author of the Presence doesn't seem to maintain it anymore, nor the others he created (the last commit he made on one of these Presences seems to date back to March 2023).
And if I come up with any other ideas for adding functionality to this Presence, I'll be happy to add them :)
Let me know what you think and if you find this change legitimate. If not, I'll change it according to your guidelines.
theusaf
approved these changes
Oct 29, 2024
Bas950
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add privacy mode and update timestamps
Acknowledgements
yarn formatScreenshots
Proof showing the creation/modification is working as expected
With privacy mode off:
With privacy mode on :
